linux-kernel - Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2016 10:56:05 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Valdis Kletnieks <Valdis.Kletnieks@...edu>,
        Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>
Cc:     Randy Dunlap <randy.dunlap@...cle.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP

On Sep 21 2016 07:14, Valdis Kletnieks wrote:
> ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
>
> ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

As a nitpicking, I think it better to change the subject line with a 
prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.

> diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig
> index 8ffcf48097d9..39b400392d71 100644
> --- a/sound/usb/line6/Kconfig
> +++ b/sound/usb/line6/Kconfig
> @@ -2,6 +2,7 @@ config SND_USB_LINE6
>  	tristate
>  	select SND_RAWMIDI
>  	select SND_PCM
> +	select SND_HWDEP
>
>  config SND_USB_POD
>  	tristate "Line 6 POD USB support"


Thanks

Takashi Sakamoto