linux-kernel - Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk2e5l97y.wl-tiwai@suse.de>
Date:   Wed, 21 Sep 2016 14:37:37 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Takashi Sakamoto <o-takashi@...amocchi.jp>
Cc:     Valdis Kletnieks <Valdis.Kletnieks@...edu>,
        Jaroslav Kysela <perex@...ex.cz>,
        Randy Dunlap <randy.dunlap@...cle.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP

On Wed, 21 Sep 2016 03:56:05 +0200,
Takashi Sakamoto wrote:
> 
> On Sep 21 2016 07:14, Valdis Kletnieks wrote:
> > ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
> >
> > ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!
> > scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> > make[1]: *** [__modpost] Error 1
> >
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> 
> As a nitpicking, I think it better to change the subject line with a
> prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our
> fashion.

Yes, I modified the subject line and added fixes tag.


thanks,

Takashi


> > diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig
> > index 8ffcf48097d9..39b400392d71 100644
> > --- a/sound/usb/line6/Kconfig
> > +++ b/sound/usb/line6/Kconfig
> > @@ -2,6 +2,7 @@ config SND_USB_LINE6
> >  	tristate
> >  	select SND_RAWMIDI
> >  	select SND_PCM
> > +	select SND_HWDEP
> >
> >  config SND_USB_POD
> >  	tristate "Line 6 POD USB support"
> 
> 
> Thanks
> 
> Takashi Sakamoto
>