linux-kernel - Re: [PATCH 47/61] perf c2c report: Add cacheline browser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160921125540.GB16793@krava>
Date:   Wed, 21 Sep 2016 14:55:40 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 47/61] perf c2c report: Add cacheline browser

On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote:
> On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote:
> > On Mon, 19 Sep 2016 15:09:56 +0200
> > Jiri Olsa <jolsa@...nel.org> wrote:
> > 
> > > +	/* reset abort key so that it can get Ctrl-C as a key */
> > > +	SLang_reset_tty();
> > > +	SLang_init_tty(0, 0, 0);
> > 
> > this fails to build on systems without slang:
> > 
> >   CC       builtin-c2c.o
> > builtin-c2c.c: In function ‘perf_c2c__browse_cacheline’:
> > builtin-c2c.c:2211:2: error: implicit declaration of function ‘SLang_reset_tty’ [-Werror=implicit-function-declaration]
> >   SLang_reset_tty();
> 
> will fix, thanks

fixed branch pushed in perf/c2c_v4

jirka