linux-kernel - Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org>
Date:   Wed, 21 Sep 2016 12:17:51 +0200
From:   Cédric Le Goater <clg@...d.org>
To:     Joel Stanley <joel@....id.au>, minyard@....org
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc

On 09/21/2016 12:05 PM, Joel Stanley wrote:
> devm_ioremap_resource returns ERR_PTR so we can't check for NULL.

Thanks for spotting this.

Acked-by: Cédric Le Goater <clg@...d.org>

C. 

> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  drivers/char/ipmi/bt-bmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index 2e880bf0be26..de64bf1f2f4d 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)
>  	}
>  
>  	bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
> -	if (!bt_bmc->base)
> -		return -ENOMEM;
> +	if (IS_ERR(bt_bmc->base))
> +		return PTR_ERR(bt_bmc->base);
>  
>  	mutex_init(&bt_bmc->mutex);
>  	init_waitqueue_head(&bt_bmc->queue);
>