linux-kernel - Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3eafb21f-f716-c04b-41c6-ce2f4e7701f7@acm.org>
Date:   Wed, 21 Sep 2016 11:34:10 -0500
From:   Corey Minyard <minyard@....org>
To:     Cédric Le Goater <clg@...d.org>,
        Joel Stanley <joel@....id.au>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc

On 09/21/2016 05:17 AM, Cédric Le Goater wrote:
> On 09/21/2016 12:05 PM, Joel Stanley wrote:
>> devm_ioremap_resource returns ERR_PTR so we can't check for NULL.
> Thanks for spotting this.
>
> Acked-by: Cédric Le Goater <clg@...d.org>

Thanks, I've pull this into my tree.

-corey

> C.
>
>> Signed-off-by: Joel Stanley <joel@....id.au>
>> ---
>>   drivers/char/ipmi/bt-bmc.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
>> index 2e880bf0be26..de64bf1f2f4d 100644
>> --- a/drivers/char/ipmi/bt-bmc.c
>> +++ b/drivers/char/ipmi/bt-bmc.c
>> @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)
>>   	}
>>   
>>   	bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
>> -	if (!bt_bmc->base)
>> -		return -ENOMEM;
>> +	if (IS_ERR(bt_bmc->base))
>> +		return PTR_ERR(bt_bmc->base);
>>   
>>   	mutex_init(&bt_bmc->mutex);
>>   	init_waitqueue_head(&bt_bmc->queue);
>>