linux-kernel - Re: [PATCH] x86: fix kdump, cleanup aborted E820_PRAM max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49fuotngu0.fsf@segfault.boston.devel.redhat.com>
Date:   Wed, 21 Sep 2016 16:22:31 -0400
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     x86@...nel.org, Boaz Harrosh <boaz@...xistor.com>,
        linux-nvdimm@...1.01.org, "H. Peter Anvin" <hpa@...or.com>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Zhang Yi <yizhan@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] x86: fix kdump, cleanup aborted E820_PRAM max_pfn manipulation

Dan Williams <dan.j.williams@...el.com> writes:

> In commit ec776ef6bbe1 "x86/mm: Add support for the non-standard
> protected e820 type" Christoph references the original patch I wrote
> implementing pmem support.  The intent of the 'max_pfn' changes in that
> commit were to enable persistent memory ranges to be covered by the
> struct page memmap by default.  However, that approach was abandoned
> when Christoph ported the patches [1], and that functionality has since
> been replaced by devm_memremap_pages().
>
> In the meantime, this max_pfn manipulation is confusing kdump [2] that
> assumes that everything covered by the max_pfn is "System RAM".  This
> results in kdump hanging or crashing.

That was my assumption, I'm not certain that the kdump code is assuming
the pmem region is usable as RAM.  The end result is a hung kdump
kernel.

> [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-March/000348.html
> [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1351098
>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Ross Zwisler <ross.zwisler@...ux.intel.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Boaz Harrosh <boaz@...xistor.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Reported-by: Zhang Yi <yizhan@...hat.com>
> Reported-by: Jeff Moyer <jmoyer@...hat.com>
> Tested-by: Zhang Yi <yizhan@...hat.com>

I actually did the testing.  You can leave that line as is, though, as
I'm sure Yi will also test it.  :)

> Fixes: ec776ef6bbe1 ("x86/mm: Add support for the non-standard protected e820 type")
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>

Thanks, Dan!

-Jeff