linux-kernel - Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1609211612280.42217@chino.kir.corp.google.com>
Date:   Wed, 21 Sep 2016 16:15:42 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     zijun_hu <zijun_hu@...o.com>
cc:     zijun_hu@....com, Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org, tj@...nel.org,
        mingo@...nel.org, iamjoonsoo.kim@....com,
        mgorman@...hsingularity.net
Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for
 __insert_vmap_area()

On Thu, 22 Sep 2016, zijun_hu wrote:

> > We don't support inserting when va->va_start == tmp_va->va_end, plain and 
> > simple.  There's no reason to do so.  NACK to the patch.
> > 
> i am sorry i disagree with you because
> 1) in almost all context of vmalloc, original logic treat the special case as normal
>    for example, __find_vmap_area() or alloc_vmap_area()

The ranges are [start, end) like everywhere else.  __find_vmap_area() is 
implemented as such for the passed address.  The address is aligned in 
alloc_vmap_area(), there's no surprise here.  The logic is correct in 
__insert_vmap_area().