linux-kernel - Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160922211428.gjcawyyseixzc6je@acer>
Date:   Fri, 23 Sep 2016 00:14:28 +0300
From:   Andrey Utkin <andrey_utkin@...tmail.com>
To:     becher.jannik@...il.com
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jannik@...il.com wrote:
> I always wondered why I shouldn't make more than one change in a patch,
> but in all talks I watched they said that it's easier for them to merge
> small patches.
> So you think I should make one "big" patch and resend it?
> Thank you for taking your time.

There is "big" and then there is "big".
Walking through entire driver fixing all occurances of _same_ issues
really should be done at once. Trivial style fixes don't usually go in
huge series of commits (but BTW if you send several related patches,
please send them as series at once). And leave granularity to
conceptually different changes.