linux-kernel - [PATCH] sched/debug: check p->se.on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2016 17:50:53 +0800
From:   Zhu Yanhai <zhu.yanhai@...mail.com>
To:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, shanpei.csp@...baba-inc.com,
        jinli.zjl@...baba-inc.com, Zhu Yanhai <gaoyang.zyh@...bao.com>
Subject: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks'

From: Zhu Yanhai <gaoyang.zyh@...bao.com>

I can't see why the check was removed by commit b32e86b4. Since it was not
relevant to the subject of the commit, I guess it was just a plain typo.

Signed-off-by: Zhu Yanhai <gaoyang.zyh@...bao.com>
---
 kernel/sched/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 2a0a999..ee1ca70 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -456,7 +456,7 @@ static void print_rq(struct seq_file *m, struct rq *rq, int rq_cpu)
 
 	rcu_read_lock();
 	for_each_process_thread(g, p) {
-		if (task_cpu(p) != rq_cpu)
+		if (!p->se.on_rq || task_cpu(p) != rq_cpu)
 			continue;
 
 		print_task(m, rq, p);
-- 
2.5.5