linux-kernel - Re: [PATCH] sched/debug: check p->se.on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160922100842.GZ5008@twins.programming.kicks-ass.net>
Date:   Thu, 22 Sep 2016 12:08:42 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Zhu Yanhai <zhu.yanhai@...mail.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        shanpei.csp@...baba-inc.com, jinli.zjl@...baba-inc.com,
        Zhu Yanhai <gaoyang.zyh@...bao.com>
Subject: Re: [PATCH] sched/debug: check p->se.on_rq for 'runnable tasks'

On Thu, Sep 22, 2016 at 05:50:53PM +0800, Zhu Yanhai wrote:
> From: Zhu Yanhai <gaoyang.zyh@...bao.com>
> 
> I can't see why the check was removed by commit b32e86b4. Since it was not
> relevant to the subject of the commit, I guess it was just a plain typo.

No, it was very much on purpose. It shows all tasks now, which is much
more useful if you want to generate pretty pictures from the output.

Its a bit hard to make pretty pictures when tasks disappear all the
time.