linux-kernel - Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2758043c-44a8-2217-3e3c-28e16b503c16@gmail.com>
Date:   Thu, 22 Sep 2016 19:58:28 +0530
From:   arvind Yadav <arvind.yadav.cs@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     daniel.lezcano@...aro.org, vincent.guittot@...aro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: timer-imx-gpt: Unmap and free region
 obtained by of_iomap and kzalloc

I have changed  subject as per your review comment.

thanks,

     -Arvind


On Thursday 22 September 2016 07:46 PM, Thomas Gleixner wrote:
> On Thu, 22 Sep 2016, Arvind Yadav wrote:
>
>> Subject: clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc
> These subject lines are useless and way too long. A patch subject should
> describe the nature of the patch and not elaborate what the patch is doing
> technically.
>
>     clocksrouce/timer-imz-gpt: Prevent resource leaks in error path
>
> would be a proper subject line which makes it entirely clear what this
> patch is about.
>
>  From your subject line I have to read the patch itself to figure that
> out. It's completely irrelevant whether that resource is a mapping or
> allocated memory. The point is that the error path leaks resource(s).
>
> See Documentation/SubmittingPatches. There you'll find a lengthy
> explanation about changelogs and summary lines in particular.
>
> Thanks,
>
> 	tglx
>
>
>