linux-kernel - Re: [PATCH] staging: sm750fb: rename getChipType to get_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 14:13:52 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Moshe Green <mgmoshes@...il.com>
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type

On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote:
> Rename CamelCased function getChipType to get_chip_type.
> This issue was found by checkpatch.pl

As this is a global function, can you rename it to something like
"sm750_get_chip_type()"?  Having a driver-specific function called
get_chip_type() is not good.

thanks,

greg k-h