linux-kernel - Re: [PATCH v2] pinctrl: intel: Configure GPIO chip IRQ as wakeup interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZAfxq9BXz3goQY1n+esR9Nij_vh+9NtvkBxXAFCXtscg@mail.gmail.com>
Date:   Fri, 23 Sep 2016 15:15:00 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nilesh Bacchewar <nilesh.bacchewar@...el.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl: intel: Configure GPIO chip IRQ as wakeup interrupts

On Thu, Sep 22, 2016 at 1:35 AM, Nilesh Bacchewar
<nilesh.bacchewar@...el.com> wrote:

> On some Intel BXT platform, wake-up from suspend-to-idle on pressing
> power-button is not working. Its noticed that gpio-keys driver marking the
> second level IRQ/power-button as wake capable but Intel pintctrl
> driver is missing to mark GPIO chip/controller IRQ which first level IRQ
> as wake cable if its GPIO pin IRQ is wakeble. So, though the first level
> IRQ gets generated on power-button press, since it is not marked as
> wake capable resume/wake-up flow is not happening.
> Intel pintctrl/GPIO driver need to mark GPIO chip/controller IRQ (first
> level IRQ) as wake capable iff GPIO pin's IRQ (second level IRQ) is marked
> as wake cable.
>
> Changes in v2:
>  - Add missing irq initialisation.
>
> Signed-off-by: Nilesh Bacchewar <nilesh.bacchewar@...el.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Patch applied.

Yours,
Linus Walleij