linux-kernel - Re: [PATCH] ext4: Check for encryption feature before fscrypt_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160923215654.GB106495@google.com>
Date:   Fri, 23 Sep 2016 14:56:54 -0700
From:   Eric Biggers <ebiggers@...gle.com>
To:     Theodore Ts'o <tytso@....edu>, Richard Weinberger <richard@....at>,
        adilger.kernel@...ger.ca, linux-kernel@...r.kernel.org,
        linux-ext4@...r.kernel.org, david@...ma-star.at, jaegeuk@...nel.org
Subject: Re: [PATCH] ext4: Check for encryption feature before
 fscrypt_process_policy()

On Thu, Sep 22, 2016 at 06:38:03PM -0400, Theodore Ts'o wrote:
> 
> I think it's fine to fix it now in upstream.  It might cause some
> problems for Cyanogen developers if they want to try to use an
> upstream kernel and also enable the ext4 encryption feature, but the
> fix to make_ext4fs isn't all that hard.

Would it make sense to at least provide a helpful error message in the kernel
log?  For example:

		if (!ext4_has_feature_encrypt(sb)) {
			ext4_msg(sb, KERN_INFO,
				 "warning: process `%s' tried to set "
				 "encryption policy on filesystem without "
				 "encryption enabled.  This is not supported.  "
				 "Use 'tune2fs -O encrypt' to enable the "
				 "encryption feature flag first.",
				 current->comm);
			return -EOPNOTSUPP;
		}

Eric