lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Sep 2016 09:39:12 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: Joe Perches <joe@...ches.com>, linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() On Sat, Sep 24, 2016 at 06:32:29PM +0200, SF Markus Elfring wrote: > >> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr > >>> unsigned long flags; > >>> unsigned char u; > >> > >>> - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n"); > >>> - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys); > >>> - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed); > >>> + pr_info(",------------------ START ----------------.\n" > >>> + "| Dumping: %30s |\n" > >>> + "| Speed: %28d kHz |\n", > >>> + gameport->phys, > >>> + gameport->speed); > > > > Not the same output. > > Should the desired output be the same when the relevant data are passed by a single function call > (instead of three as before)? The desired output should not be broken in conversion, which you did. Do you know how syslog works and why the transformation is not correct. I am also curious as to why you are patching joydump? Are you working on extending it? Thanks. -- Dmitry
Powered by blists - more mailing lists