linux-kernel - Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPJzBTpp6m8GpSB+Z=Uta0ycFm8Z6PHYd2viHZDdkd+xjD4vTQ@mail.gmail.com>
Date:   Mon, 26 Sep 2016 12:20:14 +0100
From:   Gonçalo Salazar <glbsalazar@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        gregkh@...uxfoundation.org, trivial@...nel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment
 coding style

2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@...inger.net>:
> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>
>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>> Made this as a first commit.
>> Resubmitted with updated subject.
>>
>> Please let me know of any feedback you have.
>
>
> I missed this last time, but everything above the --- line goes into the
> permanent record. Are you sure you want all this to be there? Any chatty
> remarks and any description of what changed in subsequent submissions should
> be below the ---. The maintainer will see them, but they are stripped before
> they get merged into the repo.
>
> Larry

Made a mistake that should not be in the permanent record...
Should I resubmit the patch? or are you able to strip it from the submission?

Gonçalo

>
>
>>
>> Thanks,
>> Gonçalo Salazar
>>
>> Signed-off-by: Gonçalo Salazar <glbsalazar@...il.com>
>> ---
>>  drivers/staging/rtl8712/usb_intf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8712/usb_intf.c
>> b/drivers/staging/rtl8712/usb_intf.c
>> index 3fc65b2..897d462 100644
>> --- a/drivers/staging/rtl8712/usb_intf.c
>> +++ b/drivers/staging/rtl8712/usb_intf.c
>> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
>>   *
>>   * notes: drv_init() is called when the bus driver has located a card for
>> us
>>   * to support. We accept the new device by returning 0.
>> -*/
>> + */
>>  static int r871xu_drv_init(struct usb_interface *pusb_intf,
>>                            const struct usb_device_id *pdid)
>>  {
>>
>