lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 26 Sep 2016 13:14:04 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Gonçalo Salazar <glbsalazar@...il.com>
Cc:     Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        gregkh@...uxfoundation.org, trivial@...nel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment
 coding style

On 09/26/2016 06:20 AM, Gonçalo Salazar wrote:
> 2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@...inger.net>:
>> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>>
>>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>>> Made this as a first commit.
>>> Resubmitted with updated subject.
>>>
>>> Please let me know of any feedback you have.
>>
>>
>> I missed this last time, but everything above the --- line goes into the
>> permanent record. Are you sure you want all this to be there? Any chatty
>> remarks and any description of what changed in subsequent submissions should
>> be below the ---. The maintainer will see them, but they are stripped before
>> they get merged into the repo.
>>
>> Larry
>
> Made a mistake that should not be in the permanent record...
> Should I resubmit the patch? or are you able to strip it from the submission?

I am not the one that applies the patches; however, it would be unreasonable to 
expect the maintainer to edit any patch. You need to submit V3.

Larry

>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ