lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Sep 2016 14:13:35 +0200 From: Rafał Miłecki <zajec5@...il.com> To: Arend Van Spriel <arend.vanspriel@...adcom.com> Cc: Kalle Valo <kvalo@...eaurora.org>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>, Franky Lin <frankyl@...adcom.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" <brcm80211-dev-list.pdl@...adcom.com>, Network Development <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Rafał Miłecki <rafal@...ecki.pl> Subject: Re: [PATCH] brcmfmac: implement more accurate skb tracking On 26 September 2016 at 13:46, Arend Van Spriel <arend.vanspriel@...adcom.com> wrote: > On 26-9-2016 12:23, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@...ecki.pl> >> >> We need to track 802.1x packets to know if there are any pending ones >> for transmission. This is required for performing key update in the >> firmware. > > The problem we are trying to solve is a pretty old one. The problem is > that wpa_supplicant uses two separate code paths: EAPOL messaging > through data path and key configuration though nl80211. Can I find it described/reported somewhere? >> Unfortunately our old tracking code wasn't very accurate. It was >> treating skb as pending as soon as it was passed by the netif. Actual >> handling packet to the firmware was happening later as brcmfmac >> internally queues them and uses its own worker(s). > > That does not seem right. As soon as we get a 1x packet we need to wait > with key configuration regardless whether it is still in the driver or > handed over to firmware already. OK, thanks.
Powered by blists - more mailing lists