linux-kernel - Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160926160831.e5gd4t4fqhkxgzii@sirena.org.uk>
Date:   Mon, 26 Sep 2016 09:08:31 -0700
From:   Mark Brown <broonie@...nel.org>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Helen Koike <helen.koike@...labora.co.uk>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Sebastian Reichel <sre@...nel.org>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from
 power disable path

On Mon, Sep 26, 2016 at 01:35:50PM +0300, Nikita Yushchenko wrote:

> I doubt that copying 7 lines into error path is better than having a tiny
> logic with return values, but still here it is.

Consider what happens if someone wants to change the code... 

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)