linux-kernel - Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2016 19:14:50 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from
 power disable path

>> I doubt that copying 7 lines into error path is better than having a tiny
>> logic with return values, but still here it is.
> 
> Consider what happens if someone wants to change the code... 

I believe that "undo poweron" and "poweroff" sequences still will have
to remain the same. This having two copies of code is more error-prone
than having one.

Nikita