linux-kernel - Re: [PATCH] staging: vt6656: Add spaces around '+' operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 08:49:08 -0300
From:   Martin Alonso <martin.alonso@...o.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     forest@...ttletooquiet.net, pasteka@...si.at,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Add spaces around '+' operator

On Tue, Sep 27, 2016 at 01:10:04PM +0200, Greg KH wrote:
> On Mon, Sep 26, 2016 at 02:48:24PM -0300, Martin Alonso wrote:
> > Fix coding style issue "spaces preferred around '+'
> > detected by checkpatch.pl in dpc.c file.
> > 
> > Signed-off-by: Martin Alonso <martin.alonso@...o.com>
> > ---
> >  drivers/staging/vt6656/dpc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
> > index 6019aac..900cd5c 100644
> > --- a/drivers/staging/vt6656/dpc.c
> > +++ b/drivers/staging/vt6656/dpc.c
> > @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
> >  
> >  	skb_data = (u8 *)skb->data;
> >  
> > -	rx_sts = skb_data+4;
> > -	rx_rate = skb_data+5;
> > +	rx_sts = skb_data + 4;
> > +	rx_rate = skb_data + 5;
> >  
> >  	/* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */
> >  	/* -8TSF - 4RSR - 4SQ3 - ?Padding */
> > -- 
> > 2.8.0
> > 
> 
> Doesn't apply to my tree, did someone do this before you?  You are
> working against linux-next, right?
> 
> thanks,
> 
> greg k-h
I wasn't working against linux-next as i though.
Sorry for the annoyance.