linux-kernel - Re: [PATCH] staging: vt6656: Add spaces around '+' operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 13:59:03 -0300
From:   Martin Alonso <martin.alonso@...o.com>
To:     Joe Perches <joe@...ches.com>
Cc:     forest@...ttletooquiet.net, gregkh@...uxfoundation.org,
        pasteka@...si.at, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Add spaces around '+' operator

On Mon, Sep 26, 2016 at 11:02:33AM -0700, Joe Perches wrote:
> On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote:
> > Fix coding style issue "spaces preferred around '+'
> > detected by checkpatch.pl in dpc.c file.
> []
> > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
> []
> > @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
> >  
> > >  	skb_data = (u8 *)skb->data;
> >  
> > -	rx_sts = skb_data+4;
> > -	rx_rate = skb_data+5;
> > +	rx_sts = skb_data + 4;
> > +	rx_rate = skb_data + 5;
> >  
> >  	/* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */
> >  	/* -8TSF - 4RSR - 4SQ3 - ?Padding */
> 
> You might as well make rx_rate u8 instead of u8 *
> and change the uses of rx_rate.  rx_sts isn't used
> anywhere at all and could be removed.
> 
I'll send two patches to fix this issues.
Regards.