linux-kernel - Re: [PATCH 1/7] selftest: sync: basic tests for sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 11:51:22 -0300
From:   Emilio López <emilio.lopez@...labora.co.uk>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     shuah@...nel.org, devel@...verdev.osuosl.org,
        gustavo.padovan@...labora.co.uk, riandrews@...roid.com,
        daniel.vetter@...ll.ch, John.C.Harrison@...el.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        ghackmann@...gle.com, robdclark@...il.com,
        linux-kselftest@...r.kernel.org, maarten.lankhorst@...ux.intel.com,
        daniels@...labora.com, arve@...roid.com, emil.l.velikov@...il.com
Subject: Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

Hi,

El 27/09/16 a las 01:23, Michael Ellerman escribió:
> Emilio López <emilio.lopez@...labora.co.uk> writes:
>> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>>> Emilio López <emilio.lopez@...labora.co.uk> writes:
>>>
>>> Please don't include the *kernel* headers, they're really not meant to
>>> be used in userspace programs :)
>>>
>>>> +CFLAGS += -I../../../../usr/include/
>>>
>>> That is the correct place to get them from. They'll have been put there
>>> by 'make headers_install'.
>>
>> My inspiration here has been tools/testing/selftests/memfd/Makefile,
>> which does it this way. If I only include the ones on usr then it
>> doesn't build, as there's no sync_file.h available, even after running
>> make headers_install. How am I supposed to use the ioctls from there?
>
> It looks like it's missing from include/uapi/linux/Kbuild, you need to
> add it to the list of exported headers:

I tried that over the weekend and it worked, but I wondered if it was 
the way to go. Thanks for the confirmation :) I've sent a patch for 
that[0] now.

With that resolved, CFLAGS can just be

CFLAGS += -O2 -g -std=gnu89 -pthread -Wall -Wextra
CFLAGS += -I../../../../usr/include/

I'll wait a bit more to see if anyone else has any comments, otherwise 
I'll send a v2 in a couple of days.

Thanks!
Emilio

[0] https://lkml.org/lkml/2016/9/27/289