linux-kernel - Re: [PATCH 1/7] selftest: sync: basic tests for sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ponq6kea.fsf@concordia.ellerman.id.au>
Date:   Tue, 27 Sep 2016 14:23:25 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Emilio López <emilio.lopez@...labora.co.uk>
Cc:     shuah@...nel.org, devel@...verdev.osuosl.org,
        gustavo.padovan@...labora.co.uk, riandrews@...roid.com,
        daniel.vetter@...ll.ch, John.C.Harrison@...el.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        ghackmann@...gle.com, robdclark@...il.com,
        linux-kselftest@...r.kernel.org, maarten.lankhorst@...ux.intel.com,
        daniels@...labora.com, arve@...roid.com, emil.l.velikov@...il.com
Subject: Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework

Emilio López <emilio.lopez@...labora.co.uk> writes:
> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>> Emilio López <emilio.lopez@...labora.co.uk> writes:
>>
>> Please don't include the *kernel* headers, they're really not meant to
>> be used in userspace programs :)
>>
>>> +CFLAGS += -I../../../../usr/include/
>>
>> That is the correct place to get them from. They'll have been put there
>> by 'make headers_install'.
>
> My inspiration here has been tools/testing/selftests/memfd/Makefile, 
> which does it this way. If I only include the ones on usr then it 
> doesn't build, as there's no sync_file.h available, even after running 
> make headers_install. How am I supposed to use the ioctls from there?

It looks like it's missing from include/uapi/linux/Kbuild, you need to
add it to the list of exported headers:

diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index dd604395606b..40411b4ff012 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -397,6 +397,7 @@ header-y += stddef.h
 header-y += string.h
 header-y += suspend_ioctls.h
 header-y += swab.h
+header-y += sync_file.h
 header-y += synclink.h
 header-y += sysctl.h
 header-y += sysinfo.h


cheers