linux-kernel - Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e470819d1cfcead5966e37c00f53967@codeaurora.org>
Date:   Tue, 27 Sep 2016 15:30:22 -0700
From:   subhashj@...eaurora.org
To:     Zang Leigang <zangleigang@...ilicon.com>
Cc:     vinholikatti@...il.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>

On 2016-08-25 02:39, Zang Leigang wrote:
> Some device may cause a compatibility issue while receiving a Query 
> UPIU
> with Data Segment which does not expected.
> 
> Signed-off-by: Zang Leigang <zangleigang@...ilicon.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index f08d41a..9b21d88 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1266,9 +1266,12 @@ static void
> ufshcd_prepare_utp_query_req_upiu(struct ufs_hba *hba,
>  	ucd_req_ptr->header.dword_1 = UPIU_HEADER_DWORD(
>  			0, query->request.query_func, 0, 0);
> 
> -	/* Data segment length */
> -	ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> -			0, 0, len >> 8, (u8)len);
> +	/* Data segment length only need for WRITE_DESC */
> +	if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
> +		ucd_req_ptr->header.dword_2 =
> +			UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
> +	else
> +		ucd_req_ptr->header.dword_2 = 0;
> 
>  	/* Copy the Query Request buffer as is */
>  	memcpy(&ucd_req_ptr->qr, &query->request.upiu_req,