linux-kernel - Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1intgy5at.fsf@sermon.lab.mkp.net>
Date:   Wed, 28 Sep 2016 01:14:18 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     subhashj@...eaurora.org
Cc:     Zang Leigang <zangleigang@...ilicon.com>, vinholikatti@...il.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

>>>>> "Subhash" == subhashj  <subhashj@...eaurora.org> writes:

Subhash> Looks good to me.

> -	/* Data segment length */
> -	ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> -			0, 0, len >> 8, (u8)len);
> +	/* Data segment length only need for WRITE_DESC */
> +	if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
> +		ucd_req_ptr->header.dword_2 =
> +			UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
> +	else
> +		ucd_req_ptr->header.dword_2 = 0;

What about READ_DESC?

-- 
Martin K. Petersen	Oracle Linux Engineering