linux-kernel - RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2016 14:36:49 +0900
From:   Kiwoong Kim <kwmad.kim@...sung.com>
To:     "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        subhashj@...eaurora.org
Cc:     'Zang Leigang' <zangleigang@...ilicon.com>, vinholikatti@...il.com,
        jejb@...ux.vnet.ibm.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi-owner@...r.kernel.org
Subject: RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

Hi, Martin.

I think that the patch is correct.
UFS spec says "The Data Segment area is empty" for Read Descriptor.
I have been using similar code with it and it works.
That have been already applied in Android kernel.

Reviewed-by: Kiwoong Kim <kwmad.kim@...sung.com>

Regards.

> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
> owner@...r.kernel.org] On Behalf Of Martin K. Petersen
> Sent: Wednesday, September 28, 2016 2:14 PM
> To: subhashj@...eaurora.org
> Cc: Zang Leigang; vinholikatti@...il.com; jejb@...ux.vnet.ibm.com;
> martin.petersen@...cle.com; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-scsi-owner@...r.kernel.org
> Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR
> 
> >>>>> "Subhash" == subhashj  <subhashj@...eaurora.org> writes:
> 
> Subhash> Looks good to me.
> 
> > -	/* Data segment length */
> > -	ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> > -			0, 0, len >> 8, (u8)len);
> > +	/* Data segment length only need for WRITE_DESC */
> > +	if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
> > +		ucd_req_ptr->header.dword_2 =
> > +			UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
> > +	else
> > +		ucd_req_ptr->header.dword_2 = 0;
> 
> What about READ_DESC?
> 
> --
> Martin K. Petersen	Oracle Linux Engineering
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html