linux-kernel - Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKdAkRRMbfJWeiEWWDUPemWS9f4rzSWX4T1sp+qD9_BDoU-Jdg@mail.gmail.com>
Date:   Wed, 28 Sep 2016 10:27:43 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Moritz Fischer <moritz.fischer@...us.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Lee Jones <lee.jones@...aro.org>,
        Emilio López <emilio.lopez@...labora.co.uk>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Thierry Reding <treding@...dia.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        antonynpavlov@...il.com,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        moritz.fischer.private@...il.com, julia@...com
Subject: Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI
 version of cros-ec-spi

On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer
<moritz.fischer@...us.com> wrote:
> Add compatible string for NI version of cros-ec-spi.
>
> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
> ---
>  drivers/mfd/cros_ec_spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index ebe9b94..e4504ec 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
>                          cros_ec_spi_resume);
>
>  static const struct of_device_id cros_ec_spi_of_match[] = {
> +       { .compatible = "ni,cros-ec-spi", },

I am confused: if the 2 controllers are the same, why do we need the
new compat string, at least in the driver? Shouldn't DTS simply use
"google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi",
"google,cros-ec-spi")?

DT folks, is there clear instructions somewhere as to when
introduction of new compatible is warranted, along with the rules of
how to settle on common fallback (i.e. how to make sure that, let's
say, Linux, U-boot and FreeBSD use the same fallback compatible for
the same series of devices)?

>         { .compatible = "google,cros-ec-spi", },
>         { /* sentinel */ },
>  };
> --
> 2.7.4
>

Thanks.

-- 
Dmitry