linux-kernel - Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2016 10:32:35 -0700
From:   Moritz Fischer <moritz.fischer@...us.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Lee Jones <lee.jones@...aro.org>,
        Emilio López <emilio.lopez@...labora.co.uk>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Thierry Reding <treding@...dia.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        antonynpavlov@...il.com,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        moritz.fischer.private@...il.com, julia@...com
Subject: Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI
 version of cros-ec-spi

Dmitry,

On Wed, Sep 28, 2016 at 10:27 AM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer
> <moritz.fischer@...us.com> wrote:
>> Add compatible string for NI version of cros-ec-spi.
>>
>> Signed-off-by: Moritz Fischer <moritz.fischer@...us.com>
>> ---
>>  drivers/mfd/cros_ec_spi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
>> index ebe9b94..e4504ec 100644
>> --- a/drivers/mfd/cros_ec_spi.c
>> +++ b/drivers/mfd/cros_ec_spi.c
>> @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
>>                          cros_ec_spi_resume);
>>
>>  static const struct of_device_id cros_ec_spi_of_match[] = {
>> +       { .compatible = "ni,cros-ec-spi", },
>
> I am confused: if the 2 controllers are the same, why do we need the
> new compat string, at least in the driver? Shouldn't DTS simply use
> "google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi",
> "google,cros-ec-spi")?

It might deviate in the future, but you're right, the driver patch is
not required for now
since we can use the fallback mechanism until there really *is* a
difference. We can probably
drop this one for now.

Cheers,

Moritz