linux-kernel - Re: [PATCH] HID: add missing \n to end of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160928183954.GJ19261@mail.corp.redhat.com>
Date:   Wed, 28 Sep 2016 20:39:54 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: add missing \n to end of dev_warn messages

On Sep 27 2016 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Trival fix, dev_warn messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

> ---
>  include/linux/hid.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 75b66ec..b2ec827 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
>   */
>  static inline void hid_device_io_start(struct hid_device *hid) {
>  	if (hid->io_started) {
> -		dev_warn(&hid->dev, "io already started");
> +		dev_warn(&hid->dev, "io already started\n");
>  		return;
>  	}
>  	hid->io_started = true;
> @@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
>   */
>  static inline void hid_device_io_stop(struct hid_device *hid) {
>  	if (!hid->io_started) {
> -		dev_warn(&hid->dev, "io already stopped");
> +		dev_warn(&hid->dev, "io already stopped\n");
>  		return;
>  	}
>  	hid->io_started = false;
> -- 
> 2.9.3
>