linux-kernel - Re: [PATCH 2/2] MIPS: set NR_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82120249-b6c9-2772-427a-d7318c019a8c@imgtec.com>
Date:   Wed, 28 Sep 2016 08:58:00 +0200
From:   Marcin Nowakowski <marcin.nowakowski@...tec.com>
To:     Ralf Baechle <ralf@...ux-mips.org>
CC:     "open list:MIPS" <linux-mips@...ux-mips.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] MIPS: set NR_syscall_tables appropriately

On 27.09.2016 14:04, Ralf Baechle wrote:
> On Mon, Aug 29, 2016 at 11:30:07AM +0200, Marcin Nowakowski wrote:
>
>> Depending on the kernel configuration, up to 3 syscall tables can be
>> used in parallel - so set the number properly to ensure syscall tracing
>> is set up properly.
>>
>> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@...tec.com>
>> ---
>>  arch/mips/include/asm/unistd.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/mips/include/asm/unistd.h b/arch/mips/include/asm/unistd.h
>> index e558130..71162f3d 100644
>> --- a/arch/mips/include/asm/unistd.h
>> +++ b/arch/mips/include/asm/unistd.h
>> @@ -22,6 +22,10 @@
>>  #define NR_syscalls  (__NR_O32_Linux + __NR_O32_Linux_syscalls)
>>  #endif
>>
>> +#define NR_syscall_tables (1 + \
>> +	IS_ENABLED(CONFIG_MIPS32_O32) + \
>> +	IS_ENABLED(CONFIG_MIPS32_N32))
>> +
>>  #ifndef __ASSEMBLY__
>
> NR_syscall_tables is a new symbol but I don't see any users of this
> symbol?
>

Hi Ralf,

Patch 1/2 from this series did make use of that symbol.
However, this patch has now been superseded by a slightly different 
approach following a discussion on the original proposal ...

https://lkml.org/lkml/2016/9/16/57

Marcin