linux-kernel - [PATCH v3] staging: fbtft: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160929101326.3286-1-palminha@synopsys.com>
Date:   Thu, 29 Sep 2016 11:13:26 +0100
From:   Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
To:     <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
CC:     <thomas.petazzoni@...e-electrons.com>, <noralf@...nnes.org>,
        <gregkh@...uxfoundation.org>, <CARLOS.PALMINHA@...opsys.com>
Subject: [PATCH v3] staging: fbtft: Fix checkpatch warning

Fixed the following checkpatch warnings (task #10 of eudyptula challenge):
- removed unnecessary blank line after open brace
- NULL comparison rewritten to use '!' operator

Signed-off-by: Carlos Palminha <palminha@...opsys.com>
---
Changes v2->v3:
- Improved explanation text.
Changes v1->v2:
- Added signed-off-by and comment.

 drivers/staging/fbtft/fbtft_device.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
index e9f25dd..0883715 100644
--- a/drivers/staging/fbtft/fbtft_device.c
+++ b/drivers/staging/fbtft/fbtft_device.c
@@ -841,7 +841,6 @@ static struct fbtft_device_display displays[] = {
 			}
 		}
 	}, {
-
 		.name = "piscreen",
 		.spi = &(struct spi_board_info) {
 			.modalias = "fb_ili9486",
@@ -1418,14 +1417,14 @@ static int __init fbtft_device_init(void)
 
 	/* parse module parameter: gpios */
 	while ((p_gpio = strsep(&gpios, ","))) {
-		if (strchr(p_gpio, ':') == NULL) {
+		if (!strchr(p_gpio, ':')) {
 			pr_err("error: missing ':' in gpios parameter: %s\n",
 			       p_gpio);
 			return -EINVAL;
 		}
 		p_num = p_gpio;
 		p_name = strsep(&p_num, ":");
-		if (p_name == NULL || p_num == NULL) {
+		if (!p_name || !p_num) {
 			pr_err("something bad happened parsing gpios parameter: %s\n",
 			       p_gpio);
 			return -EINVAL;
@@ -1586,7 +1585,6 @@ static void __exit fbtft_device_exit(void)
 
 	if (p_device)
 		platform_device_unregister(p_device);
-
 }
 
 arch_initcall(fbtft_device_init);
-- 
2.9.3