linux-kernel - Re: [PATCH] mfd: lpss: Fix Intel Kaby Lake PCH-H properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160929101334.GM1218@lahna.fi.intel.com>
Date:   Thu, 29 Sep 2016 13:13:34 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Xiang A Wang <xiang.a.wang@...el.com>
Subject: Re: [PATCH] mfd: lpss: Fix Intel Kaby Lake PCH-H properties

On Thu, Sep 29, 2016 at 12:59:39PM +0300, Jarkko Nikula wrote:
> There are a few issues on Intel Kaby Lake PCH-H properties added by
> commit a6a576b78e09 ("mfd: lpss: Add Intel Kaby Lake PCH-H PCI IDs"):
> 
> - Input clock of I2C controller on Intel Kaby Lake PCH-H is 120 MHz not
>   133 MHz. This was probably copy-paste error from Intel Broxton I2C
>   properties.
> - There is no default I2C SDA hold time specified which is used when
>   ACPI doesn't provide it. I got information from Windows driver team
>   that Kaby Lake PCH-H can use the same configuration than Intel
>   Sunrisepoint PCH.
> - Common HS-UART properties are not used.
> 
> Fix these by reusing the Sunrisepoint properties on Kaby Lake PCH-H.
> 
> Fixes: a6a576b78e09 ("mfd: lpss: Add Intel Kaby Lake PCH-H PCI IDs")
> Reported-by: Xiang A Wang <xiang.a.wang@...el.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>

Thanks for fixing this!

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>