[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1e7bdfb3-0772-c152-8da1-3d22b56682b3@oracle.com>
Date: Thu, 29 Sep 2016 13:26:18 +0200
From: Vegard Nossum <vegard.nossum@...cle.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>
Cc: Willy Tarreau <w@....eu>, socketpair@...il.com,
Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
Jens Axboe <axboe@...com>, Al Viro <viro@...iv.linux.org.uk>,
linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 2/8] pipe: move limit checking logic into
pipe_set_size()
On 08/29/2016 02:21 AM, Michael Kerrisk (man-pages) wrote:
> This is a preparatory patch for following work. Move the F_SETPIPE_SZ
> limit-checking logic from pipe_fcntl() into pipe_set_size(). This
> simplifies the code a little, and allows for reworking required in
> a later patch that fixes the limit checking in pipe_set_size()
> + if ((too_many_pipe_buffers_hard(pipe->user) ||
> + too_many_pipe_buffers_soft(pipe->user)) &&
> + !capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN))
> + return -EPERM;
Some might say the indentation is off here. Not sure why checkpatch
didn't care.
Otherwise looks fine to me.
Vegard
Powered by blists - more mailing lists