linux-kernel - Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877f9usxmc.fsf@linux.intel.com>
Date:   Thu, 29 Sep 2016 15:23:39 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Manish Narani <manish.narani@...inx.com>
Cc:     k.opasiak@...sung.com, r.baldyga@...sung.com,
        peter.chen@...escale.com, mnarani@...inx.com,
        John.Youn@...opsys.com, eu@...ipetonello.com,
        i.kotrasinsk@...sung.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, anuragku@...inx.com,
        punnaia@...inx.com
Subject: Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.


Hi,

Greg KH <gregkh@...uxfoundation.org> writes:
> On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote:
>> This patch adds support to configure bulk maxburst through
>> module parameter. This parameter can be used to modify bulk
>> maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT
>> performance.
>
> Eeek, this isn't the 1990's, please don't add new module parameters :)
>
> We have much better ways of handling configuration options for a device,
> why not use them (configfs, sysfs files, etc.)?
>
> Ugh, it looks like iso_maxburst is handled this way as well.
>
> Felipe, why is this?

Yeah, g_zero has a few module parameters. In fact many of the gadget
drivers have them. This is all legacy stuff, pre-configfs. We can't
simply remove the legacy gadget drivers and tell everybody to start
using configfs ;-) That's what we want, no doubt.

That being said, we're not taking any new module parameters to any of
the gadget drivers OR UDC drivers. Anything new is configfs-only. Legacy
gadgets only get bug fixes.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)