[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e40a8107-7400-bc10-a212-563dd168aac5@users.sourceforge.net>
Date: Thu, 29 Sep 2016 17:43:57 +0200
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Theodore Ts'o <tytso@....edu>
Cc: dm-devel@...hat.com, linux-raid@...r.kernel.org,
Alasdair Kergon <agk@...hat.com>,
Mike Snitzer <snitzer@...hat.com>,
Shaohua Li <shli@...nel.org>,
Julia Lawall <julia.lawall@...6.fr>,
kernel-janitors@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in
crypt_message()
> In what bizzaro world is the "current Linux coding style convention"
Do you look at the evolution for a document like "CodingStyle"?
>> -
>> -error:
>> +show_warning:
>> DMWARN("unrecognised message received.");
>> return -EINVAL;
>> }
>
> "show_warning" is better than "error"
I got such an impression.
> when the net result of the goto is that the function returns -EINVAL?!?
Do other identifiers fit better for the desired description of "what" and "why"
by jump labels?
> Please give it up with these drive-by shooting of auto-generated patches.
This update step was not auto-generated.
There are further change possibilities where special analysis tools
can help in the corresponding software development.
> You're just embarassing yourself.
Do you find any of my update suggestions worth for further considerations?
Regards,
Markus
Powered by blists - more mailing lists