linux-kernel - Re: [PATCH] dmaengine: pxa_dma: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2016 17:45:22 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     daniel@...que.org, haojian.zhuang@...il.com, vinod.koul@...el.com,
        dan.j.williams@...el.com, linux-arm-kernel@...ts.infradead.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, xie.baoyou@....com.cn, han.fei@....com.cn,
        tang.qiang007@....com.cn
Subject: Re: [PATCH] dmaengine: pxa_dma: remove unused function

Baoyou Xie <baoyou.xie@...aro.org> writes:

> We get 1 warning when building kernel with W=1:
> drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
>
> In fact, this function is called by no one, so this patch removes it.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Okay, yet I'd rather have a revert of commit c91134d91944 ("dmaengine: pxa_dma:
add support for legacy transition") , with the commit message saying:
    The conversion of the pxa architecture is now finished for all drivers, so this
    functions has fullfilled its purpose and can now be removed.

I have a similar patch in my internal tree, but yours can very well go in, as
long as it is a revert with a statement explaining why it is necessary now and
not before.

Cheers.

--
Robert