linux-kernel - Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160930000750.GB24642@f23x64.localdomain>
Date:   Thu, 29 Sep 2016 17:07:50 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>,
        joe@...ches.com, kernel-janitors@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures

On Thu, Sep 29, 2016 at 07:19:21AM +0200, Julia Lawall wrote:
> 
> 
> On Wed, 28 Sep 2016, Darren Hart wrote:
> 
> > On Sun, Sep 11, 2016 at 03:05:59PM +0200, Julia Lawall wrote:
> >
> > Hi Julia,
> >
> > > For structure types defined in the same file or local header files, find
> > > top-level static structure declarations that have the following
> > > properties:
> > > 1. Never reassigned.
> > > 2. Address never taken
> >
> > Hrm. telem_apl_debugfs_conf is passed to the TELEM_DEBUGFS_CPU macro as the
> > second argument "data":
> >
> > #define TELEM_DEBUGFS_CPU(model, data) \
> > 	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
> >
> > And the address is taken, and later assigned to the debugfs_conf pointer.
> >
> > The usage still seems OK, but did I misunderstand the conditions?
> 
> OK, this is definitely a weakness of the script and my methodology for
> checking the results.  There was already a case of a cast that I have
> fixed up my script for, but this one is worse because it's under a macro.
> I can look into whether the cast can be changed to add a const, but for
> the time being, I think you should just drop this patch.
> 

Done! :-)

> Thanks for the careful review.
> 

Sure thing, thanks for all your work with cocci.
-- 
Darren Hart
Intel Open Source Technology Center