[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1475264510.1880.2.camel@perches.com>
Date: Fri, 30 Sep 2016 12:41:50 -0700
From: Joe Perches <joe@...ches.com>
To: Guenter Roeck <groeck@...gle.com>, Jun Li <jun.li@....com>
Cc: Guenter Roeck <groeck@...omium.org>,
Felipe Balbi <felipe.balbi@...ux.intel.com>,
Chandra Sekhar Anagani <chandra.sekhar.anagani@...el.com>,
Bruce Ashfield <bruce.ashfield@...driver.com>,
Bin Gao <bin.gao@...el.com>,
Pranav Tipnis <pranav.tipnis@...el.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
On Fri, 2016-09-30 at 12:06 -0700, Guenter Roeck wrote:
> On Thu, Sep 29, 2016 at 11:37 PM, Jun Li <jun.li@....com> wrote:
[]
> > diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
[]
> > +#define PDO_VAR(min_mv, max_mv, max_ma) \
> > + ((PDO_TYPE_VAR << PDO_TYPE_SHIFT) | \
> > + ((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << \
> > + PDO_VAR_MIN_VOLT_SHIFT) | \
> > + ((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << \
> > + PDO_VAR_MAX_VOLT_SHIFT) | \
> > + ((((max_ma) / 50) & PDO_VAR_MAX_CURR_MASK) << \
>
>
> ((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) << \
This would be easier to read if laid out differently.
#define PDO_VAR(min_mv, max_mv, max_ma) \
((PDO_TYPE_VAR << PDO_TYPE_SHIFT) | \
((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << PDO_VAR_MIN_VOLT_SHIFT) | \
((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << PDO_VAR_MAX_VOLT_SHIFT) | \
((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) << PDO_VAR_MAX_CURR_SHIFT))
Powered by blists - more mailing lists