linux-kernel - Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2016 12:06:42 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Jun Li <jun.li@....com>
Cc:     Guenter Roeck <groeck@...omium.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@...el.com>,
        Bruce Ashfield <bruce.ashfield@...driver.com>,
        Bin Gao <bin.gao@...el.com>,
        Pranav Tipnis <pranav.tipnis@...el.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

On Thu, Sep 29, 2016 at 11:37 PM, Jun Li <jun.li@....com> wrote:
> Hi Guenter,
>> -----Original Message-----
>> From: linux-usb-owner@...r.kernel.org [mailto:linux-usb-
>> owner@...r.kernel.org] On Behalf Of Guenter Roeck
>> Sent: Wednesday, August 24, 2016 5:11 AM
>> To: Felipe Balbi <felipe.balbi@...ux.intel.com>
>> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@...el.com>; Bruce
>> Ashfield <bruce.ashfield@...driver.com>; Bin Gao <bin.gao@...el.com>;
>> Pranav Tipnis <pranav.tipnis@...el.com>; Heikki Krogerus
>> <heikki.krogerus@...ux.intel.com>; linux-kernel@...r.kernel.org; linux-
>> usb@...r.kernel.org; Guenter Roeck <groeck@...omium.org>
>> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
>>
> ...
>> diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
>> new file mode 100644
>> index 000000000000..6b1679af7a25
>> --- /dev/null
>> +++ b/include/linux/usb/pd.h
>
> ...
>
>> +#define PDO_VAR(min_mv, max_mv, max_ma)                                      \
>> +     ((PDO_TYPE_VAR << PDO_TYPE_SHIFT) |                             \
>> +      ((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) <<                  \
>> +       PDO_VAR_MIN_VOLT_SHIFT) |                                     \
>> +      ((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) <<                  \
>> +       PDO_VAR_MAX_VOLT_SHIFT) |                                     \
>> +      ((((max_ma) / 50) & PDO_VAR_MAX_CURR_MASK) <<                  \
>
> ((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) <<                  \
>

Thanks, fixed. PDO_BATT has a similar problem, which I noticed while
fixing the above.

Guenter