linux-kernel - Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14918603.Xr1i9JU9lz@avalon>
Date:   Tue, 04 Oct 2016 10:59:37 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Andrey Utkin <andrey_utkin@...tmail.com>
Cc:     Harman Kalra <harman4linux@...il.com>, mchehab@...nel.org,
        gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

Hi Andrey,

On Monday 03 Oct 2016 22:52:11 Andrey Utkin wrote:
> On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote:
> >  static int iss_video_queue_setup(struct vb2_queue *vq,
> > 
> > -				 unsigned int *count, unsigned int 
*num_planes,
> > -				 unsigned int sizes[], struct device 
*alloc_devs[])
> > +			unsigned int *count, unsigned int *num_planes,
> > +			unsigned int sizes[], struct device *alloc_devs[])
> 
> 2 spaces + 3 tabs -> 2 spaces + 2 tabs? Am I seeing this correctly?
> Both ways are against CodingStyle.

It's 4 tabs + 1 space -> 3 tabs as far as I can see.

> > -	/* Try the get selection operation first and fallback to get format if
> > not -	 * implemented.
> > +	/* Try the get selection operation first and
> > +	 * fallback to get format if not implemented.
> > 
> >  	 */
> 
> This comment style is discouraged so this is at lease not perfect.
> Doesn't checkpatch complain with this change? If it doesn't, could you
> please also check with --strict, as long as you're working on style.

-- 
Regards,

Laurent Pinchart