linux-kernel - Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161005104517.GJ7143@kernel.org>
Date:   Wed, 5 Oct 2016 07:45:17 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key

Em Wed, Oct 05, 2016 at 12:46:12AM +0200, Jiri Olsa escreveu:
> On Tue, Oct 04, 2016 at 01:50:12PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu:
> > > Adding dcacheline dimension key support. It
> > > displays cacheline address as hex number.
> > > 
> > > Using c2c wrapper to standard 'dcacheline' object
> > > to defined own header and simple (just address)
> > > cacheline output.
> > 
> > So, at this point I move from:
> > 
> >   # perf c2c report
> >    Error: Invalid --fields key: `dcacheline'
> >   #
> > 
> > To:
> > 
> >   [root@...et ~]# perf c2c report
> >   Error: Unknown --fields key: `offset'
> >   Segmentation fault (core dumped)
> >   [root@...et ~]#
> 
> oops, attached patch should fix that, but I needed to change
> following patches:
> 
>   perf c2c report: Add cacheline hists processing
>   perf c2c report: Decode c2c_stats for hist entries
> 
> I updated perf/c2c_v4 branch with the fix and rebased
> to your current perf/core.. let me know if I need to
> repost
> 
> thanks,
> jirka

ok, I'm trying to fix it myself, starting with this:

+       ret = c2c_hists__init(hists, sort);
+       if (ret)
+               free(hists);
+
+       return &hists->hists;

That is on "perf c2c report: Add cacheline hists processing"
 
> 
> ---
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 335c0fd30757..74c7822460e1 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -86,7 +86,7 @@ he__get_c2c_hists(struct hist_entry *he,
>  
>  	ret = c2c_hists__init(hists, sort);
>  	if (ret)
> -		free(hists);
> +		zfree(&hists);
>  
>  	return hists;
>  }