[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <07921948-8692-67c1-8ae9-a68f0cc387c8@suse.com>
Date: Wed, 5 Oct 2016 18:41:02 +0200
From: Matthias Brugger <mbrugger@...e.com>
To: Punit Agrawal <punit.agrawal@....com>,
linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
kvmarm@...ts.cs.columbia.edu, linux-arm-kernel@...ts.infradead.org
Cc: Mark Rutland <mark.rutland@....com>,
Marc Zyngier <marc.zyngier@....com>,
Will Deacon <will.deacon@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>,
Christoffer Dall <christoffer.dall@...aro.org>
Subject: Re: [PATCH 5/7] arm64/kvm: hyp: tlb: use __tlbi() helper
On 13/09/16 12:16, Punit Agrawal wrote:
> From: Mark Rutland <mark.rutland@....com>
>
> Now that we have a __tlbi() helper, make use of this in the arm64 KVM hyp
> code to get rid of asm() boilerplate. At the same time, we simplify
> __tlb_flush_vm_context by using __flush_icache_all(), as this has the
> appropriate instruction cache maintenance and barrier.
>
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> [ rename tlbi -> __tlbi, convert additional sites, update commit log ]
> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> Acked-by: Christoffer Dall <christoffer.dall@...aro.org>
> ---
Reviewed-by: Matthias Brugger <mbrugger@...e.com>
> arch/arm64/kvm/hyp/tlb.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/tlb.c b/arch/arm64/kvm/hyp/tlb.c
> index be8177c..4cda100 100644
> --- a/arch/arm64/kvm/hyp/tlb.c
> +++ b/arch/arm64/kvm/hyp/tlb.c
> @@ -16,6 +16,7 @@
> */
>
> #include <asm/kvm_hyp.h>
> +#include <asm/tlbflush.h>
>
> static void __hyp_text __tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa)
> {
> @@ -32,7 +33,7 @@ static void __hyp_text __tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa)
> * whole of Stage-1. Weep...
> */
> ipa >>= 12;
> - asm volatile("tlbi ipas2e1is, %0" : : "r" (ipa));
> + __tlbi(ipas2e1is, ipa);
>
> /*
> * We have to ensure completion of the invalidation at Stage-2,
> @@ -41,7 +42,7 @@ static void __hyp_text __tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa)
> * the Stage-1 invalidation happened first.
> */
> dsb(ish);
> - asm volatile("tlbi vmalle1is" : : );
> + __tlbi(vmalle1is);
> dsb(ish);
> isb();
>
> @@ -60,7 +61,7 @@ static void __hyp_text __tlb_flush_vmid(struct kvm *kvm)
> write_sysreg(kvm->arch.vttbr, vttbr_el2);
> isb();
>
> - asm volatile("tlbi vmalls12e1is" : : );
> + __tlbi(vmalls12e1is);
> dsb(ish);
> isb();
>
> @@ -72,9 +73,8 @@ __alias(__tlb_flush_vmid) void __kvm_tlb_flush_vmid(struct kvm *kvm);
> static void __hyp_text __tlb_flush_vm_context(void)
> {
> dsb(ishst);
> - asm volatile("tlbi alle1is \n"
> - "ic ialluis ": : );
> - dsb(ish);
> + __tlbi(alle1is);
> + __flush_icache_all(); /* contains a dsb(ish) */
> }
>
> __alias(__tlb_flush_vm_context) void __kvm_flush_vm_context(void);
>
Powered by blists - more mailing lists