linux-kernel - Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shsa804g.fsf@belgarion.home>
Date:   Thu, 06 Oct 2016 08:25:35 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, Sergey Yanovich <ynvich@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        James Cameron <quozl@...top.org>,
        Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core

Robert Jarzmik <robert.jarzmik@...e.fr> writes:

> From: Sergey Yanovich <ynvich@...il.com>
>
> pxa2xx-uart was a separate uart platform driver. It was declaring
> the same device names and numbers as 8250 driver. As a result,
> it was impossible to use 8250 driver on PXA SoCs.
>
> Upon closer examination pxa2xx-uart turned out to be a clone of
> 8250_core driver.
>
> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
> Specification Update (April 19, 2010) is dropped. 8250_core reads
> from FIFO immediately after checking DR bit in LSR.
>
> The patch leaves the original SERIAL_PXA driver around. The original
> driver is just marked DEPRECATED in Kconfig and C source. When
> the original driver is considered safe to remove, no changes
> to SERIAL_8250 will be necessary.
>
> Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
> SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
> and the original drivers are made mutually exclusive.
>
> Signed-off-by: Sergei Ianovich <ynvich@...il.com>
> CC: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> CC: James Cameron <quozl@...top.org>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Robert Jarzmik <robert.jarzmik@...e.fr>
> CC: Russell King <linux@....linux.org.uk>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> [rebased on v4.8]
> Tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Greg, can you take that into you tty tree please ?

Cheers.

--
Robert