linux-kernel - Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161007153116.GD10482@kroah.com>
Date:   Fri, 7 Oct 2016 17:31:16 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Cc:     Debjit Ghosh <dghosh@...iper.net>,
        Georgi Vlaev <gvlaev@...iper.net>,
        Guenter Roeck <linux@...ck-us.net>,
        Mohammad Kamil <mkamil@...iper.net>,
        Rajat Jain <rajatjain@...iper.net>,
        Shyamshankar Dharmarajan <shyamd@...iper.net>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h

On Fri, Oct 07, 2016 at 06:15:46PM +0300, Pantelis Antoniou wrote:
> From: Rajat Jain <rajatjain@...iper.net>
> 
> Add this header to contain the PCI device IDs that we cannot add in
> the linux pci_ids.h.

Why can't you?

> This would contain PCI device IDs of Juniper devices as well as any
> PCIe switches etc.

Why do you need a .h file for this?  Is the values in it shared across
drivers?  If not, you don't nee a .h file at all.  If so, then it
belongs in pci_ids.h as the top of that file describes.

thanks,

greg k-h