linux-kernel - Re: [PATCH 0/2] Juniper infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161007152848.GA10482@kroah.com>
Date:   Fri, 7 Oct 2016 17:28:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Cc:     Debjit Ghosh <dghosh@...iper.net>,
        Georgi Vlaev <gvlaev@...iper.net>,
        Guenter Roeck <linux@...ck-us.net>,
        Mohammad Kamil <mkamil@...iper.net>,
        Rajat Jain <rajatjain@...iper.net>,
        Shyamshankar Dharmarajan <shyamd@...iper.net>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 0/2] Juniper infrastructure

On Fri, Oct 07, 2016 at 06:15:44PM +0300, Pantelis Antoniou wrote:
> Introduce a staging driver containing all the bit and
> pieces of Juniper's board support infrastructure that don't quite
> fit in any other place.

Why staging?

> The Juniper series of routers comprise of both x86 and powerpc
> platforms that contain similar hardware components necessitating
> common support methods.
> 
> Note that this is the first submission and we expect things to be
> moved around as required.
> 
> This patchset is against mainline as of today: v4.8-9431-g3477d16
> and is dependent on the "Juniper prerequisites" patchset sent
> earlier.

sent where?  Why not just make a single patch series?

> Rajat Jain (1):
>   jnx: Introduce include/linux/jnx/pci_ids.h
> 
> Tom Kavanagh (1):
>   staging: jnx: Juniper subsystem & board core APIs
> 
>  Documentation/ABI/testing/sysfs-platform-jnx | 170 +++++++
>  drivers/staging/Kconfig                      |   2 +
>  drivers/staging/Makefile                     |   1 +
>  drivers/staging/jnx/Kconfig                  |  24 +
>  drivers/staging/jnx/Makefile                 |   5 +
>  drivers/staging/jnx/jnx-board-core.c         | 247 ++++++++++
>  drivers/staging/jnx/jnx-subsys-private.h     |  35 ++
>  drivers/staging/jnx/jnx-subsys.c             | 655 +++++++++++++++++++++++++++
>  include/linux/jnx/jnx-board-core.h           |  41 ++
>  include/linux/jnx/jnx-subsys.h               |  94 ++++
>  include/linux/jnx/pci_ids.h                  |  66 +++


staging drivers have to be self-contained, no files outside of your
subdirectory please.

Once they have "passed" proper review, then you can move files out.

Also, I need a TODO file listing what needs to be done, who to contact,
and other info about the code.

And again, why not just submit this to the real part of the kernel?

thanks,

greg k-h