linux-kernel - Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161008170837.GB8747@intel.com>
Date:   Sat, 8 Oct 2016 20:08:37 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        "tpmdd-devel@...ts.sourceforge.net" 
        <tpmdd-devel@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

On Sat, Oct 08, 2016 at 10:42:03AM -0600, Jason Gunthorpe wrote:
> On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote:
> 
> > Rather you it would be better not to use cmdReady/goIdle at all if
> > kernel is not compiled with CONFIG_PM.
> 
> It would be best practice to ensure the tpm is powered up no matter
> how the kernel is compiled.. The firmware may have left it in idle or
> something
> 
> FWIW, I broadly agree there is no need to put the device into idle on
> the error paths. It probably wasn't idle when the driver attached to
> it.

I'll keep the current commit because it's anyway tested code.

If I want to change this I'll send a separate patch for review.

> Jason

/Jarkko