linux-kernel - Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for brcm-iproc-pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b29ebaa-eaaa-2f77-6408-a476af3aaa84@broadcom.com>
Date:   Sat, 8 Oct 2016 14:02:51 -0700
From:   Ray Jui <ray.jui@...adcom.com>
To:     Scott Branden <scott.branden@...adcom.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v3] pwm: add depends, COMPILE_TEST and default y for
 brcm-iproc-pwm



On 10/8/2016 1:54 PM, Scott Branden wrote:
> - Add depends on COMMON_CLK for PWM_BCM_IPROC
> - Enable COMPILE_TEST for broader compile coverage.
> - Default y for IPROC PWM driver for IPROC SoCs.
> This allows you to turn it on simply by selecting CONFIG_PWM.
>
> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> ---
>  drivers/pwm/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 80a566a..3eb1b6b 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -76,7 +76,9 @@ config PWM_ATMEL_TCB
>
>  config PWM_BCM_IPROC
>  	tristate "iProc PWM support"
> -	depends on ARCH_BCM_IPROC
> +	depends on ARCH_BCM_IPROC || COMPILE_TEST
> +	depends on COMMON_CLK
> +	default ARCH_BCM_IPROC
>  	help
>  	  Generic PWM framework driver for Broadcom iProc PWM block. This
>  	  block is used in Broadcom iProc SoC's.
>

Looks good to me!

Reviewed-by: Ray Jui <ray.jui@...adcom.com>