[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 10 Oct 2016 11:16:11 +0100
From: David Vrabel <david.vrabel@...rix.com>
To: Paul Durrant <paul.durrant@...rix.com>,
<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xenproject.org>
CC: Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH v2] xenbus: advertize control feature flags
On 10/10/16 10:43, Paul Durrant wrote:
> The Xen docs specify several flags which a guest can set to advertize
> which values of the xenstore control/shutdown key it will recognize.
> This patch adds code to write all the relevant feature-flag keys.
[...]
> static int setup_shutdown_watcher(void)
> {
> + static struct shutdown_handler *handler;
> int err;
>
> + for (handler = &shutdown_handlers[0]; handler->command; handler++) {
> + char *node;
char node[20];
and avoid the allocation and resulting error path.
As Juergen notes, the 'flag' field isn't used anywhere now. Can you
please test your patches and verify the correct keys are being created?
David
Powered by blists - more mailing lists