linux-kernel - RE: [PATCH v2] xenbus: advertize control feature flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 10:25:50 +0000
From:   Paul Durrant <Paul.Durrant@...rix.com>
To:     David Vrabel <david.vrabel@...rix.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
CC:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>
Subject: RE: [PATCH v2] xenbus: advertize control feature flags

> -----Original Message-----
> From: David Vrabel [mailto:david.vrabel@...rix.com]
> Sent: 10 October 2016 11:16
> To: Paul Durrant <Paul.Durrant@...rix.com>; linux-kernel@...r.kernel.org;
> xen-devel@...ts.xenproject.org
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>; Juergen Gross
> <jgross@...e.com>
> Subject: Re: [PATCH v2] xenbus: advertize control feature flags
> 
> On 10/10/16 10:43, Paul Durrant wrote:
> > The Xen docs specify several flags which a guest can set to advertize
> > which values of the xenstore control/shutdown key it will recognize.
> > This patch adds code to write all the relevant feature-flag keys.
> [...]
> >  static int setup_shutdown_watcher(void)
> >  {
> > +	static struct shutdown_handler *handler;
> >  	int err;
> >
> > +	for (handler = &shutdown_handlers[0]; handler->command;
> handler++) {
> > +		char *node;
> 
> char node[20];

I didn't want to pick arbitrary numbers. I'd prefer to stick with kasprintf().

  Paul

> 
> and avoid the allocation and resulting error path.
> 
> As Juergen notes, the 'flag' field isn't used anywhere now.  Can you
> please test your patches and verify the correct keys are being created?
> 
> David